Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not select when opening href on selectable elements #963

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

nielslyngsoe
Copy link
Member

A fix to avoid selection happening when clicking or keyboard interacting with sub element of a selectable element.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-963.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Nov 25, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-963.westeurope.azurestaticapps.net

@leekelleher leekelleher self-requested a review November 25, 2024 10:00
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, works as expected. 👍

@nielslyngsoe nielslyngsoe merged commit ea35e87 into v1/contrib Nov 25, 2024
11 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/do-not-select-when-opening branch November 25, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants